Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs and some test changes to help debug test failure in Test_CLI_Delete #6880

Closed
wants to merge 32 commits into from

Conversation

vinayada1
Copy link
Contributor

@vinayada1 vinayada1 commented Nov 29, 2023

Description

Changes to debug test failure issue: #6872

  1. Used a different app name and namespace for the failing test instead of reusing from a previous one in the file
  2. Added more logs

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Auto-generated summary

🤖[deprecated] Generated by Copilot at 5cffd1b

Summary

📥🔐🗑️

This pull request implements a new workflow for triggering the functional tests that requires approval from a team member, and adds and modifies test cases to cover the delete command behavior with unassociated resources. It also removes the /ok-to-test command from the radius-bot.js script, fixes a typo and a formatting issue in the workflow and the CLI files, and enhances the logging of the validation package. Additionally, it introduces three new workflow files to save and download the pull request number as an artifact.

We are the masters of the code, we shape it as we please
We trigger tests with our approval, we guard the secrets of the keys
We fix the bugs and format the logs, we delete what we don't need
We save the artifacts of our work, we are the pull request breed

Walkthrough

  • Disable /ok-to-test command and replace it with approval workflow for triggering functional tests (link, link, link, link)
  • Save pull request number as an artifact and download it in functional tests workflow (link, link, link, link)
  • Fix a typo in the bug report body in functional-test.yaml (link)
  • Fix a formatting issue in the log message in delete.go (link)
  • Add a log message for the number of deployed resources in k8s.go (link)
  • Add a parameter and a log message for the expected and actual labels in matchesActualLabels function in k8s.go (link, link)
  • Add a new test data file and a new variable for an application with unassociated resources in cli_test.go (link, link, link)
  • Replace existing test cases with new test cases that check the behavior of the delete command when there are unassociated resources in cli_test.go (link, link, link)

@vinayada1 vinayada1 requested review from a team as code owners November 29, 2023 23:05
@vinayada1 vinayada1 changed the title Cli delete fail Logs and some test changes to help debug test failure in Test_CLI_Delete Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant