-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs and some test changes to help debug test failure in Test_CLI_Delete #6880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayada1
changed the title
Cli delete fail
Logs and some test changes to help debug test failure in Test_CLI_Delete
Nov 29, 2023
… to make it work via forks Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
Signed-off-by: vinayada1 <28875764+vinayada1@users.noreply.github.com>
vinayada1
force-pushed
the
cli-delete-fail
branch
from
November 29, 2023 23:06
5cffd1b
to
06325ca
Compare
vinayada1
had a problem deploying
to
functional-tests
December 29, 2023 23:06 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to debug test failure issue: #6872
Type of change
Auto-generated summary
🤖[deprecated] Generated by Copilot at 5cffd1b
Summary
📥🔐🗑️
This pull request implements a new workflow for triggering the functional tests that requires approval from a team member, and adds and modifies test cases to cover the delete command behavior with unassociated resources. It also removes the
/ok-to-test
command from theradius-bot.js
script, fixes a typo and a formatting issue in the workflow and the CLI files, and enhances the logging of the validation package. Additionally, it introduces three new workflow files to save and download the pull request number as an artifact.Walkthrough
/ok-to-test
command and replace it with approval workflow for triggering functional tests (link, link, link, link)functional-test.yaml
(link)delete.go
(link)k8s.go
(link)matchesActualLabels
function ink8s.go
(link, link)cli_test.go
(link, link, link)cli_test.go
(link, link, link)