Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #6624

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Update README.md #6624

merged 1 commit into from
Nov 1, 2023

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Nov 1, 2023

Description

Update release doc.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Auto-generated summary

🤖 Generated by Copilot at 1bc8d01

Summary

✏️📝✔️

Fix documentation errors in contributing-releases guide. This improves the readability and accuracy of the guide for contributors and users.

We are the ones who fix the docs
We purge the errors from the text
We wield the power of the backticks
We make the releases shine and flex

Walkthrough

  • Fix typos, grammar, and punctuation errors in docs/contributing/contributing-releases/README.md (link, link, link, link, link, link)
  • Remove obsolete step of purging CDN cache from release process in docs/contributing/contributing-releases/README.md (link)

@ytimocin ytimocin requested review from a team as code owners November 1, 2023 19:53

1. Cherry-pick the `version.yaml` changes and release notes onto the branch from the PR opened against main. This will ensure that the release notes are included in the release branch. [Example](https://github.com/radius-project/radius/pull/6114/files). The release branch should now contain all needed patch changes, an updated release version, and patch release notes.
1. Cherry-pick the `version.yaml` changes and release notes onto the branch from the PR opened against the main. This will ensure that the release notes are included in the release branch. [Example](https://github.com/radius-project/radius/pull/6114/files). The release branch should now contain all needed patch changes, an updated release version, and patch release notes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the main branch


1. Push the commits to the remote and create a pull request targeting the release branch.
```bash
git push origin <USERNAME>/<BRANCHNAME>
```

1. Merge the release branch PR into the release branch (this is the branch with the patch changes, updated patch version, and release notes). Then, merge the PR created against `main` into the main branch (this will only contain the updated patch version and the release notes). The release branch changes must be merged before the PR is merged into main since the workflow in the main branch builds the release based on the head of the release branch. If the changes are not merged first to the release branch and then to the main branch, the patch release will not contain the necessary code fixes.
1. Merge the release branch PR into the release branch (this is the branch with the patch changes, updated patch version, and release notes). Then, merge the PR created against `main` into the main branch (this will only contain the updated patch version and the release notes). The release branch changes must be merged before the PR is merged into the main since the workflow in the main branch builds the release based on the head of the release branch. If the changes are not merged first to the release branch and then to the main branch, the patch release will not contain the necessary code fixes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the main branch

sk593
sk593 previously approved these changes Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Test Results

3 003 tests  ±0   2 991 ✔️ ±0   3m 5s ⏱️ +24s
   258 suites ±0        12 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 57b2d93. ± Comparison against base commit 3c6d337.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/c00d7577-6617-46af-84a0-ee503e1f0d69
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/c00d7577-6617-46af-84a0-ee503e1f0d69#01
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/f6e17121-60ed-42d9-bc68-db6cece7d6d2
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/f6e17121-60ed-42d9-bc68-db6cece7d6d2#01

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 1, 2023

65.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.1 %
  • main branch coverage: 65.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
Signed-off-by: ytimocin <ytimocin@microsoft.com>
@ytimocin ytimocin force-pushed the ytimocin/release-doc-update branch from 4ac4e2a to 57b2d93 Compare November 1, 2023 22:00
@ytimocin ytimocin requested a review from sk593 November 1, 2023 22:01
Copy link

github-actions bot commented Nov 1, 2023

65.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.1 %
  • main branch coverage: 65.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@ytimocin ytimocin merged commit a330410 into main Nov 1, 2023
@ytimocin ytimocin deleted the ytimocin/release-doc-update branch November 1, 2023 23:21
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Nov 3, 2023
# Description
Update release doc.

## Type of change
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

## Auto-generated summary
<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at 1bc8d01</samp>

### Summary
:pencil2::memo::heavy_check_mark:

<!--
1. :pencil2: - This emoji represents the correction of typos, spelling,
and grammar errors. For example, line 9 was changed from "This document
describes how to contribute to the releases of the project." to "This
document describes how to contribute to the project's releases."
2. :memo: - This emoji represents the improvement of formatting, style,
and consistency. For example, line 15 was changed from "The project
follows the [Semantic Versioning](https://semver.org/) convention for
its releases." to "The project follows the [Semantic
Versioning](https://semver.org/) (SemVer) convention for its releases."
to introduce the acronym for later use.
3. ✔️ - This emoji represents the clarification and
enhancement of the information and instructions. For example, line 25
was changed from "The project uses [GitHub
milestones](https://docs.github.com/en/github/managing-your-work-on-github/about-milestones)
to track the progress and scope of each release." to "The project uses
[GitHub
milestones](https://docs.github.com/en/github/managing-your-work-on-github/about-milestones)
to track the progress and scope of each release. Each milestone
corresponds to a specific version number and release date." to provide
more details and context.
-->
Fix documentation errors in `contributing-releases` guide. This improves
the readability and accuracy of the guide for contributors and users.

> _We are the ones who fix the docs_
> _We purge the errors from the text_
> _We wield the power of the backticks_
> _We make the releases shine and flex_

### Walkthrough
* Fix typos, grammar, and punctuation errors in
`docs/contributing/contributing-releases/README.md`
([link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL30-R30),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL40-R40),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL63-R55),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL75-R75),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL96-R90),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL105-R97))
* Remove obsolete step of purging CDN cache from release process in
`docs/contributing/contributing-releases/README.md`
([link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL47-L54))

Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
Signed-off-by: ytimocin <ytimocin@microsoft.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
willdavsmith pushed a commit that referenced this pull request Nov 6, 2023
# Description
Update release doc.

## Type of change
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

## Auto-generated summary
<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at 1bc8d01</samp>

### Summary
:pencil2::memo::heavy_check_mark:

<!--
1. :pencil2: - This emoji represents the correction of typos, spelling,
and grammar errors. For example, line 9 was changed from "This document
describes how to contribute to the releases of the project." to "This
document describes how to contribute to the project's releases."
2. :memo: - This emoji represents the improvement of formatting, style,
and consistency. For example, line 15 was changed from "The project
follows the [Semantic Versioning](https://semver.org/) convention for
its releases." to "The project follows the [Semantic
Versioning](https://semver.org/) (SemVer) convention for its releases."
to introduce the acronym for later use.
3. ✔️ - This emoji represents the clarification and
enhancement of the information and instructions. For example, line 25
was changed from "The project uses [GitHub
milestones](https://docs.github.com/en/github/managing-your-work-on-github/about-milestones)
to track the progress and scope of each release." to "The project uses
[GitHub
milestones](https://docs.github.com/en/github/managing-your-work-on-github/about-milestones)
to track the progress and scope of each release. Each milestone
corresponds to a specific version number and release date." to provide
more details and context.
-->
Fix documentation errors in `contributing-releases` guide. This improves
the readability and accuracy of the guide for contributors and users.

> _We are the ones who fix the docs_
> _We purge the errors from the text_
> _We wield the power of the backticks_
> _We make the releases shine and flex_

### Walkthrough
* Fix typos, grammar, and punctuation errors in
`docs/contributing/contributing-releases/README.md`
([link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL30-R30),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL40-R40),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL63-R55),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL75-R75),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL96-R90),
[link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL105-R97))
* Remove obsolete step of purging CDN cache from release process in
`docs/contributing/contributing-releases/README.md`
([link](https://github.com/radius-project/radius/pull/6624/files?diff=unified&w=0#diff-4b032acb8e706dca3cf78512aadf53ee8b05354e51cd46023ed550c0625b33fbL47-L54))

Signed-off-by: Yetkin Timocin <ytimocin@microsoft.com>
Signed-off-by: ytimocin <ytimocin@microsoft.com>
Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants