-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remoteaddr to reduce attribute cardinality #5514
Conversation
There is the similar problem due to the high cardinality from remoteaddr port : open-telemetry/opentelemetry-go#3765 |
Test Results2 514 tests ±0 2 507 ✔️ ±0 1m 57s ⏱️ +2s Results for commit cb232fe. ± Comparison against base commit 42a6f1b. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.39.0 | ||
go.opentelemetry.io/contrib/instrumentation/runtime v0.39.0 | ||
go.opentelemetry.io/otel v1.13.0 | ||
go.opentelemetry.io/otel/exporters/prometheus v0.36.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these package version changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. these are all related :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is just one small typo but other than that LGTM
Co-authored-by: Yetkin Timocin <ytimocin@microsoft.com>
@vinayada1 Once you validate the change, please approve this pr :) |
Description
otelhttp has the high cardinality problem which record all remote address from client. This issue is tracked by open-telemetry/opentelemetry-go-contrib#3765 .
This PR is adding workaround to prevent otelhttp from recording remoteaddr as an attribute.
Issue reference
#5299
#5237
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: