Pulling rad CLI edge binaries includes a directory path #6633
Assignees
Comments
willdavsmith
changed the title
./dist/os_arch/release/rad
|
👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up. We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue. For more information on our triage process please visit our triage overview |
willdavsmith
added a commit
that referenced
this issue
Nov 3, 2023
…elease/rad` (#6634) # Description This fixes the edge rad publishing to be just the binary instead of the full path ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #6633 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 5d814c2</samp> ### Summary :package::whale::zap: <!-- 1. :package: This emoji represents the packaging or bundling of the rad binary into a single file that can be easily distributed and executed. It also implies that the change is related to the build or release process of the project. 2. :whale: This emoji represents the Docker or container aspect of the change, as it involves pushing the rad binary to a container registry using oras. It also implies that the change is related to the deployment or distribution of the project. 3. :zap: This emoji represents the optimization or performance improvement of the change, as it reduces the image size and removes unnecessary files from the image. It also implies that the change is related to the speed or efficiency of the project. --> The pull request optimizes the image size and structure of the `rad` cli binaries by copying them to the root directory before pushing them with `oras`. The change affects the `.github/workflows/build.yaml` file. > _`rad` binary copied_ > _to root before container push_ > _smaller image, spring cleaning_ ### Walkthrough * Copy rad binary to root directory before pushing to container registry ([link](https://github.com/radius-project/radius/pull/6634/files?diff=unified&w=0#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L219-R225)) Signed-off-by: willdavsmith <willdavsmith@gmail.com>
willdavsmith
added a commit
to willdavsmith/radius
that referenced
this issue
Nov 3, 2023
…elease/rad` (radius-project#6634) # Description This fixes the edge rad publishing to be just the binary instead of the full path ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6633 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 5d814c2</samp> ### Summary :package::whale::zap: <!-- 1. :package: This emoji represents the packaging or bundling of the rad binary into a single file that can be easily distributed and executed. It also implies that the change is related to the build or release process of the project. 2. :whale: This emoji represents the Docker or container aspect of the change, as it involves pushing the rad binary to a container registry using oras. It also implies that the change is related to the deployment or distribution of the project. 3. :zap: This emoji represents the optimization or performance improvement of the change, as it reduces the image size and removes unnecessary files from the image. It also implies that the change is related to the speed or efficiency of the project. --> The pull request optimizes the image size and structure of the `rad` cli binaries by copying them to the root directory before pushing them with `oras`. The change affects the `.github/workflows/build.yaml` file. > _`rad` binary copied_ > _to root before container push_ > _smaller image, spring cleaning_ ### Walkthrough * Copy rad binary to root directory before pushing to container registry ([link](https://github.com/radius-project/radius/pull/6634/files?diff=unified&w=0#diff-d0777657fa3fd81d23aaf7273e58aee453b04e67882517900c56daeef9b3e4c1L219-R225)) Signed-off-by: willdavsmith <willdavsmith@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug information
Steps to reproduce (required)
Pull the latest rad edge from GHCR
oras pull ghcr.io/radius-project/rad/darwin-arm64:latestObserved behavior (required)
ORAS will pull the artifact and a folder structure like
./dist/os_arch/release/radDesired behavior (required)
The OCI artifact should be
./radinstead of./dist/os_arch/release/radWorkaround (optional)
Download the file and move it manually
System information
rad Version (required)
Operating system (required)
MacOS Ventura 13.6
AB#10009
The text was updated successfully, but these errors were encountered: