Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand test coverage #854

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Expand test coverage #854

merged 5 commits into from
Mar 13, 2023

Commits on Mar 13, 2023

  1. try to expand test coverage 

    expand test coverage

fix test failure for dask

trivial whitespace change?

try to emulate astropy/astroquery#2626

that last one seems to maybe have broken CI?  undoing the CI changes

try putting things on one line ?

try changing ubuntu-latest to linux based on the versions-manifest, which doesn't mention ubuntu at all

try changing 3.10 -> '3.10' instead of the linux change

shorten job names so we can see the whole name in the sidebar of gh-actions

add a mask setter to solve problem where numpy masked arrays are trying
to set the mask attribute but being blocked from doing so

drop openfiles b/c it's deprecated (not sure what we're supposed to
replace it with yet)

make some of the failing tests more extensive and explicit
    @keflavich
    keflavich committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    aafcd64 View commit details
    Browse the repository at this point in the history

  2. split a test onto more lines to try to pin down where the error is co… 

    …ming from (pdb revealed that code that succeeded on the previous line is the direct source of this failure)

fix mistake

add a new test for "all"

add all-dev and remove -openfiles from windoze

move dev dependenc installs from tox to setup.cfg

whitespace and naming

expand test coverage yet again: try dev w/o novis/all

separate out 'viz' from 'noviz'

fix a typo....

add extras that were all missing into tox.ini

make sure basic tests use latest numpy

rearrange and make tests more granular still

drop 3.7 from grid b/c astropy 5.2.1 doesn't support it

see if pvextractor can be included in the "good" viz

hack around astropy 14514

hack needs to be hackier b/c _new_view didn't always have finalize= option

try to run tests w/dev branch

fix syntax

fix install url

fix name again?

try to fix last exception

allow for three types of error?  this might not be the right approach

fix test again

remove mask setter - I'm not sure it was actually needed, I think that might have been a side-effect error caused by something else?  Pushing this to run tests to check; may neeed to partially revert this if tests fail

set ndim

fix the naxis defn

restore the mask setter, it _is_ needed

reproject high_level_wcs fix merged; revert to master in tests

fix names of # of dims
    @keflavich
    keflavich committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    1abb821 View commit details
    Browse the repository at this point in the history

  3. revert to my branch, even though it was merged, to see if that can ma… 

    …ke tests go green again
    @keflavich
    keflavich committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6951e56 View commit details
    Browse the repository at this point in the history

  4. try using astropy nightly wheels. This might inadvertently make tests… 

    … go green for <24h b/c the breaking change is <8h old, but the intent is to make builds faster

change order of commands

oh, I just had stupidly pasted in setup.cfg too
    @keflavich
    keflavich committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ef841c0 View commit details
    Browse the repository at this point in the history

  5. put some sticky tape over the check engine light.

    @keflavich
    keflavich committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d0b15f9 View commit details
    Browse the repository at this point in the history