Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure proper resource info for RA #3185

Merged
merged 1 commit into from
May 30, 2024
Merged

ensure proper resource info for RA #3185

merged 1 commit into from
May 30, 2024

Conversation

andre-merzky
Copy link
Member

This is needed by util plots for runs where pilot size was defined in nodes.

@andre-merzky
Copy link
Member Author

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 44.71%. Comparing base (427f117) to head (f43f834).

Files Patch % Lines
src/radical/pilot/utils/prof_utils.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3185      +/-   ##
==========================================
- Coverage   44.75%   44.71%   -0.05%     
==========================================
  Files          94       94              
  Lines       10278    10288      +10     
==========================================
  Hits         4600     4600              
- Misses       5678     5688      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(at first I missed the point, but I got that it is just to fill up pilot description if cores/gpus were not set)

@andre-merzky
Copy link
Member Author

LGTM! (at first I missed the point, but I got that it is just to fill up pilot description if cores/gpus were not set)

Yes, precisely :-) Thanks!

@andre-merzky andre-merzky merged commit b7857e1 into devel May 30, 2024
28 checks passed
@andre-merzky andre-merzky deleted the fix/node_resources branch May 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants