Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOW 2 #1504
SOW 2 #1504
Changes from all commits
debb65e
a9ec446
116e0c2
61e2e9b
b626fc2
0c908c6
d41db40
645d105
70dbcd2
273db7b
541bd5a
72ead85
0995cd6
62c302d
5ba130b
2c0850d
5237cbc
cdc48d0
d66a632
bc17b67
d555184
4b535a1
9b50e1a
d65ce11
dab6884
143b328
66e0404
75b3f17
27e8f2d
5ebd9dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using hungarian notation
run_log_f
for file andrun_d
for directory. Long local variable names also don't have a lot of value, especially when they are just cached values like this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
_path
here is specifically to distinguish the path string from the file object. Using_f
to mean "not a file object" seems confusing :-).run_dir
seems to be used pretty consistently inserver.py
andsimulation_db.py
, so I used it everywhere here too, but we can switch if you want...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to validate the jhash, because could be a different job