83 intrinsic bandwidth #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 100TW amplifier notebook that makes use of these changes can be found here: https://github.com/radiasoft/rslaser-examples/blob/main/laser_propagation/amplifier_100TW_Bella.ipynb |
bruhwiler
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Tests are passing, except for the check on API changes that will break Sirepo.
@moellep and @gurhar1133 -- this PR will break Sirepo.
The example notebook is running correctly and showing good results.
The updated code looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passing, except for the one intended to notify the software team (fails because of change to tau_0 and tau_fwhm requirements)