Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for env_prefix config setting #29

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

dekkers
Copy link
Contributor

@dekkers dekkers commented Jan 8, 2024

This adds support for the env_prefix config setting by prepending the prefix to the field name.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e67c91) 100.00% compared to head (41da98c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          135       135           
  Branches        31        31           
=========================================
  Hits           135       135           
Flag Coverage Δ
integration_tests 90.37% <100.00%> (ø)
total 100.00% <100.00%> (ø)
unit_tests 64.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@radeklat radeklat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for an A+ pull request! 🎉 Nothing to add other than kudos for implementing this missing functionality ❤️

@radeklat radeklat merged commit f144c6b into radeklat:main Jan 31, 2024
9 checks passed
@dekkers dekkers deleted the add-env-prefix-support branch February 6, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants