[mono] Remove w32error code (dotnet#66846)

The remaining usages can be removed.

src/mono/mono/metadata/CMakeLists.txt

@@ -32,12 +32,10 @@ else()
 endif()
 
 set(metadata_win32_sources
-    w32event-win32.c
-    w32error-win32.c)
+    w32event-win32.c)
 
 set(metadata_unix_sources
-    w32event-unix.c
-    w32error-unix.c)
+    w32event-unix.c)
 
 if(HOST_WIN32)
 set(metadata_platform_sources ${metadata_win32_sources})
@@ -155,7 +153,6 @@ set(metadata_common_sources
     w32event.h
     w32handle.h
     w32handle.c
-    w32error.h
     reflection.c
     dynamic-image.c
     sre.c

src/mono/mono/metadata/image.c

@@ -51,7 +51,6 @@
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
 #endif
-#include <mono/metadata/w32error.h>
 
 #define INVALID_ADDRESS 0xffffffff
 
@@ -1809,7 +1808,7 @@ mono_image_open_a_lot_parameterized (MonoLoadedImages *li, MonoAssemblyLoadConte
 		fname_utf16 = g_utf8_to_utf16 (absfname, -1, NULL, NULL, NULL);
 		module_handle = MonoLoadImage (fname_utf16);
 		if (status && module_handle == NULL)
-			last_error = mono_w32error_get_last ();
+			last_error = GetLastError ();
 
 		/* mono_image_open_from_module_handle is called by _CorDllMain. */
 		image = (MonoImage*)g_hash_table_lookup (loaded_images, absfname);

src/mono/mono/metadata/threads.c

@@ -53,7 +53,6 @@
 
 #include <mono/metadata/reflection-internals.h>
 #include <mono/metadata/abi-details.h>
-#include <mono/metadata/w32error.h>
 #include <mono/utils/w32api.h>
 #include <mono/utils/mono-os-wait.h>
 #include <mono/metadata/exception-internals.h>
@@ -1270,7 +1269,7 @@ start_wrapper (gpointer data)
 }
 
 static void
-throw_thread_start_exception (guint32 error_code, MonoError *error)
+throw_thread_start_exception (const char *msg, MonoError *error)
 {
 	ERROR_DECL (method_error);
 
@@ -1282,9 +1281,7 @@ throw_thread_start_exception (guint32 error_code, MonoError *error)
 	MONO_STATIC_POINTER_INIT_END (MonoMethod, throw_method)
 	g_assert (throw_method);
 
-	char *msg = g_strdup_printf ("0x%x", error_code);
 	MonoException *ex = mono_get_exception_execution_engine (msg);
-	g_free (msg);
 
 	gpointer args [1];
 	args [0] = ex;
@@ -1365,7 +1362,13 @@ create_thread (MonoThread *thread, MonoInternalThread *internal, MonoThreadStart
 		mono_g_hash_table_remove (threads_starting_up, thread);
 		mono_threads_unlock ();
 
-		throw_thread_start_exception (mono_w32error_get_last(), error);
+#if HOST_WIN32
+		char *err_msg = g_strdup_printf ("0x%x", GetLastError ());
+		throw_thread_start_exception (err_msg, error);
+		g_free (err_msg);
+#else
+		throw_thread_start_exception ("mono_thread_platform_create_thread() failed", error);
+#endif
 
 		/* ref is not going to be decremented in start_wrapper_internal */
 		mono_atomic_dec_i32 (&start_info->ref);

src/mono/mono/metadata/w32event-unix.c

@@ -10,7 +10,6 @@
 
 #include "w32event.h"
 
-#include "w32error.h"
 #include "mono/utils/mono-error-internals.h"
 #include "mono/utils/mono-logger-internals.h"
 #include "mono/metadata/handle.h"
@@ -108,17 +107,7 @@ mono_w32event_init (void)
 gpointer
 mono_w32event_create (gboolean manual, gboolean initial)
 {
-	/* Need to blow away any old errors here, because code tests
-	 * for ERROR_ALREADY_EXISTS on success (!) to see if an event
-	 * was freshly created */
-	mono_w32error_set_last (ERROR_SUCCESS);
-
-	gpointer handle = event_create (manual, initial);
-
-	gint32 win32error = mono_w32error_get_last ();
-	g_assert ((win32error != ERROR_SUCCESS) == !handle);
-
-	return handle;
+	return event_create (manual, initial);
 
 }
 
@@ -140,7 +129,6 @@ static gpointer event_handle_create (MonoW32HandleEvent *event_handle, MonoW32Ty
 	if (handle == INVALID_HANDLE_VALUE) {
 		g_warning ("%s: error creating %s handle",
 			__func__, mono_w32handle_get_typename (type));
-		mono_w32error_set_last (ERROR_GEN_FAILURE);
 		return NULL;
 	}
 
@@ -181,13 +169,11 @@ mono_w32event_set (gpointer handle)
 
 	if (!mono_w32handle_lookup_and_ref (handle, &handle_data)) {
 		g_warning ("%s: unkown handle %p", __func__, handle);
-		mono_w32error_set_last (ERROR_INVALID_HANDLE);
 		return;
 	}
 
 	if (handle_data->type != MONO_W32TYPE_EVENT) {
 		g_warning ("%s: unkown event handle %p", __func__, handle);
-		mono_w32error_set_last (ERROR_INVALID_HANDLE);
 		mono_w32handle_unref (handle_data);
 		return;
 	}