Ciam Update #2 #11
Merged
Ciam Update #2 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 14, 2018 15:28
…o work better with main; modified some ciam.jl documentation (no code changes)
…deleted old single-segment test folders
… functions from test.jl to ciamhelper.jl (to write results and run the model). Fixed some paths for run_tests.jl. Added segment subsets to data directory; removed data/results directory
|
This is great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the newest update that fixes all issues identified in the full 12000-segment comparison. It includes some code changes to ciam.jl to accomodate the original model's treatment of Greenland and island segments, as well as some restructuring and reordering of the folder system.
All segments now fully match the GAMS version, with the exception of cases where dropped/rounded decimal points in our current local sea level rise data have led to inconsistencies.