-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical tests do not output all levels #141
Comments
Thanks for a thorough bug report. Generally, I tend to rely on Gradle for test information in order to ensure good backward and forward compatibility. Let me see what's causing this in a bit more detail and advise. |
You've got a bigger test suite than you could possibly ever need by just running This is a Kotlin test framework built on top of Junit5 that uses arbitrarily nested scopes for testing. Many of the test cases for the framework itself use 2/3/4 levels of nesting. |
Looks good. I'd probably have Test lined up on the left and indent after
that. Or maybe just have the word Test for top level entries.
…On Fri, 28 Feb 2020 at 10:57, Adarsh Ramamurthy ***@***.***> wrote:
Not sure if it's pretty at this point, but I seem to be getting somewhere:
[image: image]
<https://user-images.githubusercontent.com/534512/75568534-5991dd00-5a4b-11ea-8398-0e0bfa059795.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141?email_source=notifications&email_token=AAFVSGXWXBXHU6ENJ5W67J3RFE66NA5CNFSM4KJLTC5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENJGU6Y#issuecomment-592603771>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGSYPWXHEMCWHHHQ7YDRFE66NANCNFSM4KJLTC5A>
.
|
It looks odd in this case because there are tests being nested directly within other tests (unlike JUnit where classes containing tests are nested within tests). Let me see if I can detect this difference in the plugin and render the output correctly. |
Junit has three states - container, container_test and test. In gradle
prior to 6.0, it would hang if you used container_test. So you might want
to handle container_test and container the same way.
…On Sat, 29 Feb 2020 at 11:41, Adarsh Ramamurthy ***@***.***> wrote:
It looks odd in this case because there are tests being nested directly
within other tests (unlike JUnit where classes containing tests are nested
within tests). Let me see if I can detect this difference in the plugin and
render the output correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#141?email_source=notifications&email_token=AAFVSGV3SCH43EHSY7HQJG3RFFEDPA5CNFSM4KJLTC5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMAY5Y#issuecomment-592972919>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGXTWCCVOXVYAU5X3ILRFFEDPANCNFSM4KJLTC5A>
.
|
are you going to display the names of the nested test classes, as well as the names of the tests? |
@Hives yes that's the plan. I've got most of it sorted now. Just need to work out a good design (UI) for displaying tests that are directly nested within other tests. Also, for completeness, I'm going to verify that it works well for each style of kotest and spek framework for Kotlin based tests. |
🙏 |
Description
Hierarchical tests do not output correctly.
Versions
Type of test being run
Kotest.io
Test logger configuration
Default.
Screenshots
These tests have multiple levels to them but only one level is output.
Additional information
This might not be an issue with this project. Gradle does the exact same thing. But there's been open bugs in gradle for 2 years+ so I'm hoping we can fix it here instead (plus the output of this plugin is far better).
The text was updated successfully, but these errors were encountered: