Skip to content
This repository was archived by the owner on Apr 21, 2021. It is now read-only.

Add r2commodore #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add r2commodore #3

wants to merge 1 commit into from

Conversation

thestr4ng3r
Copy link

The cat build/install-manifest.txt | xargs rm -v will not work unless the commands will be executed in a shell. I have no idea how to do it with the current r2pm state. Do you maybe have an idea, @qbarrand?

It's kind of surprising that the ~ expansion actually works, I am not sure at which point exactly it is expanded.

By the way it is quite tedious that the working directory can't be changed by cd because every next command will be run on its own from the root. cd somewhere && do something doesn't work as well because again there is no shell.

This kind of brings me back to https://github.com/radareorg/r2pm/issues/47
cc @XVilka @radare @xarkes

@qbarrand
Copy link
Collaborator

I guess that adopting the format described in https://github.com/radareorg/r2pm/pull/64/files would solve your problem, right? You would have to maintain that manifest yourself, though.

Comments on that PR are welcome, BTW.

@thestr4ng3r
Copy link
Author

Yes, the {{ .DestPath }} will perfectly solve the -DCMAKE_INSTALL_PREFIX=~/.local, but the other things are still somewhat problematic.

@qbarrand
Copy link
Collaborator

I'm not sure how to address the cd thing, to be honest. As you said, cd is a shell builtin and the goal of the new r2pm is indeed to get rid of shell dependencies.

Regarding ~, cmake is probably expanding it.

And finally regarding the manifest, I don't think it's wise to encourage packagers to run make install - that's how you end up with files from package A being overwritten by package B. Providing a list of files in the out section of the YAML file, as proposed in the PR, deals with this problem: r2pm can check if a file exists before copying it, and knows what to remove when uninstalling a package. RPM packages also specify a list of the paths that they own, for example.

@thestr4ng3r
Copy link
Author

Agreed, the out section is a much better solution than global make install.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants