Removes higher level API functions from r2pipe.rs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove all higher-level structs * Remove certain functions used to interact with the r2 instance and retrieve specific information This functionality aims to be moved to r2pipe.rs-frontend repository.
|
do you prefer radare2-r2pipe-api/rust repository or just put the stuff inside radare2-r2pipe/api/rust/…
… On 10 Jul 2017, at 19:32, Chinmay Deshpande ***@***.***> wrote:
This is a API breaking change.
Moves r2pipe to 0.5.0.
TODO:
Add README notice
Bump version
Creation of the r2pipe.rs-frontend(tentative) repository
Stable version of the crate on Cargo
libsmt.rs
radeco
radeco-lib
rune
esil-rs
This functionality is to be moved to a newer repository. This is in-line with the discussion here <#18>. Multiple projects require wrappers around certain specific r2 features and pancake deemed it necessary to separate the core pipe-based logic and higher level constructs into a different project.
This PR will be updated with links to PRs to other r2-based dependent repositories.
@radare <https://github.com/radare> have a look. This should only be merged when all of the above projects have been stabilized to use the newer API.
You can view, comment on, or merge this pull request online at:
#23 <#23>
Commit Summary
This aims to make the following changes:
File Changes
M src/lib.rs <https://github.com/radare/r2pipe.rs/pull/23/files#diff-0> (5)
M src/r2.rs <https://github.com/radare/r2pipe.rs/pull/23/files#diff-1> (142)
D src/structs.rs <https://github.com/radare/r2pipe.rs/pull/23/files#diff-2> (127)
Patch Links:
https://github.com/radare/r2pipe.rs/pull/23.patch <https://github.com/radare/r2pipe.rs/pull/23.patch>
https://github.com/radare/r2pipe.rs/pull/23.diff <https://github.com/radare/r2pipe.rs/pull/23.diff>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#23>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-ljnitC8lX7seSBEpewJjqtorXNK1ks5sMmArgaJpZM4OTKiw>.
|
|
I think either is fine. To keep up with the convention and abstain from creating additional repositories, I think adding it as folder under the name "rust" is just fine. Although, we might need to setup the test framework accordingly for each API folder. |
|
the repo was created, see radare2-r2pipe-api
i think it makes sense to put it in a separate place to add proper discussion about this in there and not mess the issues with r2pipe.
… On 11 Jul 2017, at 19:20, Chinmay Deshpande ***@***.***> wrote:
I think either is fine. To keep up with the convention and abstain from creating additional repositories, I think adding it as folder under the name "rust" is just fine. Although, we might need to setup the test framework accordingly for each API folder.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-loVQJcGOjI-quTh3EIlF3lMuXV01ks5sM67mgaJpZM4OTKiw>.
|
|
@radare, I think you can merge this PR and then have look over at radeco-lib and merge that as well. |
chinmaydd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a API breaking change.
Bumps r2pipe to 0.5.0.
TODO:
Stable version of the crate on Cargo(Not needed, see here)rsocbranch PR)This functionality is to be moved to a newer repository. This is in-line with the discussion here. Multiple projects require wrappers around certain specific r2 features and pancake deemed it necessary to separate the core pipe-based logic and higher level constructs into a different project.
This PR will be updated with links to PRs to other r2-based dependent repositories.
@radare have a look. This should only be merged when all of the above projects have been stabilized to use the newer API.