Skip to content

Commit

Permalink
removed "locked" condition from Stack.requires (#105)
Browse files Browse the repository at this point in the history
* removed "locked" condition from `Stack.requires`, update changelog

* add patch note to setup.py
  • Loading branch information
ITProKyle authored and troyready committed Dec 18, 2019
1 parent 1971fd4 commit f05ef52
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- `DEPLOY_ENVIRONMENT` is available to all module deployments as an environment variable
- if it does not exist in the current environment, value is derived from branch or directory name
- Updated static site CFN template to use node v10 for path rewrite lambda
- embedded stacker will not resolve dependancies for `locked` stacks when they rely on other stacks
- accepted upstream in https://github.com/cloudtools/stacker/pull/746

## [1.3.3] - 2019-11-26
### Changed
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
# and the following patches applied
# https://github.com/cloudtools/stacker/pull/731 (CAPABILITY_AUTO_EXPAND)
# https://github.com/cloudtools/stacker/pull/744 (diffs via CFN changesets)
# https://github.com/cloudtools/stacker/pull/746 (locked stack dependencies)
# and the following files/folders deleted:
# * tests
# * blueprints/testutil.py
Expand Down
6 changes: 0 additions & 6 deletions src/runway/embedded/stacker/stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ def required_by(self):

@property
def requires(self):
# By definition, a locked stack has no dependencies, because we won't
# be performing an update operation on the stack. This means, resolving
# outputs from dependencies is unnecessary.
if self.locked and not self.force:
return []

requires = set(self.definition.requires or [])

# Add any dependencies based on output lookups
Expand Down

0 comments on commit f05ef52

Please sign in to comment.