[doc]: Clarify end behavior in vector-sort[!] when set to #f
#5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorawee
reviewed
Nov 24, 2024
| @mz-examples[#:eval vec-eval | ||
| (define v1 (vector 4 3 2 1)) | ||
| (vector-sort v1 <) | ||
| v1 |
There was a problem hiding this comment.
I think the point of having v1 after (vector-sort v1 <) originally is to show whether vector-sort has side-effect. So we should either move v1 to the end of the sequences of (vector-sort v1 ....). Alternatively, if you don't think it's worth the effort to do the demonstratation, then we should just delete the lone v1 / v2.
shhyou
added
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
This PR updates the
vector-sortandvector-sort!documentation to clarify the behavior of theendandkey.