fix(gwapi): allow custom nginx.conf #463
Conversation
LukeRepko
force-pushed
the
development
branch
2 times, most recently
from
3eaf352 to
ba8f482
Compare
There is no easy way to add `proxy_buffer_size` or similar parameters to Nginx via CRD. A feature for the same is being worked on and might be released early November per nginx/nginx-gateway-fabric#1398 (comment) As a workaround, this change includes the default nginx configuration as deployed in the current version of nginx gateway fabric. It will be made available to the nginx pod at `/etc/nginx/nginx.conf` by supplanting the nginx-gateway deployment with a kustomize patch that overrides `nginx.conf` via a mounted configMap volume containing said file. Several additional parameters, `proxy_buffer_size` and `proxy_buffers` are being included at this time, to account for some large header payloads being proxied from Gnocchi.
LukeRepko
force-pushed
the
development
branch
from
e645e9e to
50c8d59
Compare
|
Still testing this in the lab, it's working as expected so far, but there are a few other things I want to check before it's ready for review. |
|
Deployed this to our DFW staging environment by means of a helm upgrade - this worked as expected. |
|
Looks good to me. |
|
Hey @LukeRepko, was going through some old conversations and came across this. We did implement SnippetFilters where you would be able to specify this kind of configuration (or most other NGINX customizations) in YAML. If you get a chance, we'd love to know how well it works, or if it works, for you guys! |
|
Thank you for the heads up @mpstefan - that's great news! I've created an internal story for our team to test and implement the same if it works as expected. Considering what we have in our backlog it will likely take a bit to implement, but I've left a note to follow-up here to let you know how it works out. Jira: OSPC-990 |
There is no easy way to add
proxy_buffer_sizeor similar parameters to Nginx via CRD. A feature for the same is being worked on and might be released early November per nginxinc/nginx-gateway-fabric/#1398.As a workaround, this change includes the default nginx configuration as deployed in the current version of nginx gateway fabric. It will be made available to the nginx pod at
/etc/nginx/nginx.confby supplanting the nginx-gateway deployment with a kustomize patch that overridesnginx.confvia a mounted configMap volume containing said file.Several additional parameters,
proxy_buffer_sizeandproxy_buffersare being included at this time, to account for some large header payloads being proxied from Gnocchi.