follow_direct: Include rack.session.options #233
Conversation
perlun
changed the title
spec/fixtures/fake_app.rb
Outdated
| @@ -30,7 +30,7 @@ class FakeApp < Sinatra::Base | |||
|
|
|||
| %i[get put post delete].each do |meth| | |||
| send(meth, '/redirected') do | |||
| additional_info = meth == :get ? ", session #{session}" : " using #{meth} with #{params}" | |||
| additional_info = meth == :get ? ", session #{session}#{request.session_options}" : " using #{meth} with #{params}" | |||
There was a problem hiding this comment.
If you change
", session #{session}#{request.session_options}"
to this instead, I think it would be more readable code:
", session #{session} with options #{request.session_options}"
|
@perlun anything I can do to help get this across the finish line? It's holding up a few gem updates for us. Thanks! |
|
@perlun Checking in on this as well. Happy to help if there's anything I can do... ? |
|
There we go, merged @markedmondson and @jhubert - thanks for your help. Please use the gem from GitHub for now (using the |
|
Hey @perlun - any idea when your going to get this into a release? |
|
Spooky. I had the exact same question (to myself) about 3 hours ago. |
|
Mind meld 🧠 |
|
@bwinter @markedmondson and others: 1.1.0 released for your pleasure: https://github.com/rack-test/rack-test/releases/tag/v1.1.0 |
|
Thanks @perlun! |
* Include session options in request * Use consistent testing pattern * Increase allowed ClassLength * Add more description to the body output
Should resolve #231