Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set license to MIT in .gemspec #130

Merged
merged 1 commit into from
May 2, 2017
Merged

Explicitly set license to MIT in .gemspec #130

merged 1 commit into from
May 2, 2017

Conversation

benders
Copy link
Contributor

@benders benders commented Jul 9, 2015

This will help out any tooling that reads the gemspec instead of scanning the contents.

@benders
Explicitly set license to MIT in .gemspec
270a526 
This will help out any tooling that reads the gemspec instead of scanning the contents.
perlun
perlun approved these changes May 2, 2017
View reviewed changes
Copy link
Contributor

@perlun perlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@perlun perlun merged commit 995ae03 into rack:master May 2, 2017
@junaruga
Copy link
Contributor

junaruga commented May 8, 2017

@perlun Maybe we have to update Thorfile file for that, as the gemspec file is generated from Thorfile.

@junaruga
Copy link
Contributor

junaruga commented May 8, 2017 •
edited
Loading

@perlun actually you added 2nd s.license = 'MIT' to the gemspec file.
I am going to send PR to fix this considering Thorfile soon.

@junaruga junaruga mentioned this pull request May 8, 2017
Merged
alex-damian-negru pushed a commit to alex-damian-negru/rack-test that referenced this pull request Apr 5, 2021
@benders
Explicitly set license to MIT in .gemspec (rack#130)
1c1c1c9 
This will help out any tooling that reads the gemspec instead of scanning the contents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perlun perlun perlun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benders @junaruga @perlun