Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Chain<Chain<Chain<Chain ... #848

Merged
merged 1 commit into from
May 11, 2018
Merged

Remove Chain<Chain<Chain<Chain ... #848

merged 1 commit into from
May 11, 2018

Conversation

jwilm
Copy link
Collaborator

@jwilm jwilm commented May 11, 2018

Thanks, impl Trait!

@kngwyu
Copy link
Collaborator

kngwyu commented May 11, 2018 •
edited
Loading

Looks fine for me.
But now by rust-lang/rust#49896, some string methods like starts_with are declared in macro so we have some broken tests(see also kngwyu@6df7414).
So let's merge this PR after fixing them.

@kngwyu kngwyu merged commit 4abaf61 into master May 11, 2018
@kngwyu
Copy link
Collaborator

kngwyu commented May 11, 2018

Thanks！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwilm @kngwyu