determineVersion.sh: prevent traversing into outer git repo for git-describe call #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escribe call When building nethogs inside another git repo (as is i.e. done as part of a buildroot build) the version is picked up from the outer git repo, which is confusing as well as introducing reproducibility problems when rebuilding the same nethogs version produces different results if the outer repository changes.
raboof
approved these changes
Sep 20, 2024
|
Thanks! Were you at the r-b summit? I couldn't make it this year sadly! |
|
That was fast! :-) Yep, I was there. Only for two days though, as my time in the moment is also a bit limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building nethogs inside another git repo (as is i.e. done as part of a buildroot build) the version is picked up from the outer git repo, which is confusing as well as introducing reproducibility problems when rebuilding the same nethogs version produces different results if the outer repository changes.