Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClientOptionsBuilder #210

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

alfredotg
Copy link
Contributor

@alfredotg alfredotg commented Feb 2, 2024

Hello.
I was trying to use Client directly in my code, as in examples/raw_client.rs, and couldn't find a way to create ClientOptions

  • Added ClientOptionsBuilder
  • Added test

fix clippy warning
@wolf4ood wolf4ood self-requested a review February 6, 2024 09:04
Copy link
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alfredotg thanks for this PR
LGTM

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f44f71) 88.31% compared to head (ed05391) 88.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   88.31%   88.13%   -0.19%     
==========================================
  Files          68       68              
  Lines        5650     5817     +167     
==========================================
+ Hits         4990     5127     +137     
- Misses        660      690      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanielePalaia DanielePalaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@wolf4ood wolf4ood merged commit 7db8d45 into rabbitmq:main Feb 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants