Tls client certificate #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
tls_client_certificate
branch
from
0d3438d
to
14a845a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 86.83% 88.21% +1.37%
==========================================
Files 68 68
Lines 5501 5625 +124
==========================================
+ Hits 4777 4962 +185
+ Misses 724 663 -61
☔ View full report in Codecov by Sentry. |
DanielePalaia
force-pushed
the
tls_client_certificate
branch
from
14a845a
to
8166fb4
Compare
wolf4ood
approved these changes
Aug 24, 2023
DanielePalaia
force-pushed
the
tls_client_certificate
branch
from
8166fb4
to
e986803
Compare
|
Let's wait for this #185 to be integrated in order to write a couple of tests here before integrating. |
test to validate the TLS connection. Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
with the wrong certificate Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
@DanielePalaia @wolf4ood ready for review. |
test Recreate the certificates Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
test Recreate the certificates Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for client certifications and the possibility to trust the certificates with a trust_certificates method.
I will add tests when #185 will be ready.