Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all projects to net6.0 #76

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

lukebakken
Copy link
Contributor

Update versions to beta.4

Re-instate the ApiApproval test.

Fixes #24

@lukebakken lukebakken added this to the v1.0.0-beta.4 milestone Feb 17, 2022
@lukebakken lukebakken self-assigned this Feb 17, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #76 (ccc8b44) into main (1ea7d7c) will increase coverage by 0.18%.
The diff coverage is 75.00%.

❗ Current head ccc8b44 differs from pull request most recent head 71ec373. Consider uploading reports for the commit 71ec373 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   90.50%   90.69%   +0.18%     
==========================================
  Files          66       66              
  Lines        4413     4415       +2     
  Branches      261      261              
==========================================
+ Hits         3994     4004      +10     
+ Misses        362      355       -7     
+ Partials       57       56       -1     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/Client.cs 88.65% <66.66%> (+0.03%) ⬆️
Tests/ApiApproval.cs 14.28% <100.00%> (+14.28%) ⬆️
RabbitMQ.Stream.Client/StreamSystem.cs 89.71% <0.00%> (-0.94%) ⬇️
Tests/ClientTests.cs 97.24% <0.00%> (+0.68%) ⬆️
RabbitMQ.Stream.Client/Connection.cs 93.20% <0.00%> (+0.97%) ⬆️
RabbitMQ.Stream.Client/WireFormatting.cs 75.53% <0.00%> (+3.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea7d7c...71ec373. Read the comment docs.

@lukebakken lukebakken force-pushed the rabbitmq-stream-dotnet-client-24 branch from 71ec373 to 10fd687 Compare February 17, 2022 18:09
Update versions to beta.4

Re-instate the ApiApproval test.

Bump cache versions, add skip for ApiApproval on Linux

Ensure net6.0 is available on Windows

See if a longer close timeout fixes a flaky test.
@lukebakken lukebakken marked this pull request as ready for review February 17, 2022 19:07
@lukebakken lukebakken merged commit 89390aa into main Feb 17, 2022
@lukebakken lukebakken deleted the rabbitmq-stream-dotnet-client-24 branch February 17, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target net6.0
2 participants