Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle offset not found #73

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Handle offset not found #73

merged 1 commit into from
Feb 17, 2022

Conversation

Gsantomaggio
Copy link
Member

Add specific exception in case the offset does not exist
fix the ConsumerQueryOffset test.

Add specific exception in case the offset does not exist
fix the ConsumerQueryOffset test.
@codecov-commenter
Copy link

Codecov Report

Merging #73 (995d4b1) into main (90c175d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   90.44%   90.54%   +0.10%     
==========================================
  Files          66       66              
  Lines        4386     4402      +16     
  Branches      258      260       +2     
==========================================
+ Hits         3967     3986      +19     
+ Misses        362      359       -3     
  Partials       57       57              
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/ClientExceptions.cs 61.29% <100.00%> (+5.73%) ⬆️
RabbitMQ.Stream.Client/StreamSystem.cs 90.47% <100.00%> (+0.09%) ⬆️
Tests/ConsumerSystemTests.cs 100.00% <100.00%> (ø)
Tests/Utils.cs 92.40% <100.00%> (+3.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c175d...995d4b1. Read the comment docs.

@Gsantomaggio Gsantomaggio merged commit a446027 into main Feb 17, 2022
@Gsantomaggio Gsantomaggio deleted the handle_offset_not_found branch February 17, 2022 09:05
@lukebakken lukebakken added this to the v1.0.0-beta.4 milestone Feb 17, 2022
@lukebakken
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants