-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amqp 1.0 Implementation #60
Conversation
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 88.99% 90.42% +1.43%
==========================================
Files 55 63 +8
Lines 3171 4252 +1081
Branches 132 254 +122
==========================================
+ Hits 2822 3845 +1023
- Misses 312 351 +39
- Partials 37 56 +19
Continue to review full report at Codecov.
|
Add GoClient dump files Fix write bug for properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only comment to highlight because the PR is good to go as it is is maybe to unit tests the key classes like various parsers, and utility parsers and the publish and deliver commands. I believe by having unit tested these classes we can make the other tests cases which are more collaboration tests simpler with less data assertions because we know that the serialization works in all scenarios.
Other than that, it looks good to me.
Fixes #58
AMQP 1.0 Message implementation
Disclamer:
The implementation is not completed yet.
At the moment it supports:
that are the most used attributes.
Code:
Most of the new code is inside the
AMQP
directory where you can find:AmqpWireFormatting
( divided inAmqpWireFormattingRead
andAmqpWireFormattingWrite
partial classes)The class is responsible to read/write AMQP fields with the format codes
FormatCode
with all the FormatCodesHow to test:
Unit tests: