Add RCP timeout #385
Merged
Add RCP timeout #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configuration. Check the logic status before raise set the event Fixes: #384 Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>
|
Maybe @stebet can add some comments :) ! |
lukebakken
added a commit
that referenced
this pull request
Jun 10, 2024
There is still a slim chance that the code in #385 will throw `InvalidOperationException`, since the check and call to `SetException` is not atomic. `ManualResetValueTaskSource` does not have `TrySetException` like `TaskCompletionSource`.
Merged
lukebakken
added a commit
that referenced
this pull request
Jun 10, 2024
…85-followup Follow-up to #385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuration. Check the logic status before setting the event.
Fixes: #384
Thanks to @mbaillargeon-ubi for the debug.
The PR adds also the
RpcTimeOutconfiguration: