Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user defined loopback address if available (#374) #377

Merged
merged 1 commit into from
May 21, 2024

Conversation

CoenraadS
Copy link
Contributor

When a loopback address is specified, use it directly instead of using localhost.
Because DNS resolution on localhost may resolve to IPV6 (::1), although the user may have expected an IPV4 loopback address (127.0.0.1).

Resolved #374 & #375

@lukebakken lukebakken self-assigned this May 21, 2024
@lukebakken lukebakken added this to the 1.8.2 milestone May 21, 2024
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CoenraadS are you able to test this change in your environment, since you can reproduce the issue?

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.75%. Comparing base (f2904b0) to head (0eed28b).
Report is 1 commits behind head on main.

Files Patch % Lines
RabbitMQ.Stream.Client/StreamSystem.cs 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   92.05%   91.75%   -0.30%     
==========================================
  Files         118      118              
  Lines       12102    12123      +21     
  Branches      936      938       +2     
==========================================
- Hits        11140    11124      -16     
- Misses        742      778      +36     
- Partials      220      221       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CoenraadS
Copy link
Contributor Author

CoenraadS commented May 21, 2024

Thanks!

@CoenraadS are you able to test this change in your environment, since you can reproduce the issue?

Yes, the documentation sample now works for me.

A test failed in the pipeline: ConsumerShouldReceiveDelivery, but locally it passes for me.

@CoenraadS CoenraadS changed the title Use user defined loopback address if available ( #374) Use user defined loopback address if available (#374) May 21, 2024
@Gsantomaggio Gsantomaggio modified the milestones: 1.8.2, 1.8.4 May 21, 2024
@Gsantomaggio
Copy link
Member

A test failed in the pipeline: ConsumerShouldReceiveDelivery, but locally it passes for me.

Yes, sometimes it fails on the CI. I need to check why!

Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you!

@Gsantomaggio Gsantomaggio merged commit 5250316 into rabbitmq:main May 21, 2024
2 checks passed
@lukebakken
Copy link
Contributor

@CoenraadS thank you very much!

@Gsantomaggio
Copy link
Member

FYI: https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/releases/tag/v1.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection refused when running streams sample
3 participants