-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use user defined loopback address if available (#374) #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@CoenraadS are you able to test this change in your environment, since you can reproduce the issue?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 92.05% 91.75% -0.30%
==========================================
Files 118 118
Lines 12102 12123 +21
Branches 936 938 +2
==========================================
- Hits 11140 11124 -16
- Misses 742 778 +36
- Partials 220 221 +1 ☔ View full report in Codecov by Sentry. |
Yes, the documentation sample now works for me. A test failed in the pipeline: ConsumerShouldReceiveDelivery, but locally it passes for me. |
Yes, sometimes it fails on the CI. I need to check why! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you!
@CoenraadS thank you very much! |
When a loopback address is specified, use it directly instead of using
localhost
.Because DNS resolution on
localhost
may resolve to IPV6 (::1
), although the user may have expected an IPV4 loopback address (127.0.0.1
).Resolved #374 & #375