Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read VersionString from AssemblyInformationalVersionAttribute (#365) #368

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

doerig
Copy link
Contributor

@doerig doerig commented Mar 18, 2024

Read VersionString from AssemblyInformationalVersionAttribute instead of FileVersionInfo

Fixes #365

@Gsantomaggio Gsantomaggio added this to the 1.8.2 milestone Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.08%. Comparing base (906eb83) to head (0ba1df7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   91.92%   92.08%   +0.15%     
==========================================
  Files         118      118              
  Lines       12103    12102       -1     
  Branches      936      936              
==========================================
+ Hits        11126    11144      +18     
+ Misses        756      743      -13     
+ Partials      221      215       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @doerig! We appreciate contributions from the community!

@Gsantomaggio Gsantomaggio merged commit 317f332 into rabbitmq:main Mar 19, 2024
2 checks passed
@doerig doerig deleted the support_single_file_publish branch March 20, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing as single file leads to TypeInitializationException
3 participants