Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ReadUuid. #367

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Add missing ReadUuid. #367

merged 3 commits into from
Mar 16, 2024

Conversation

bangjiehan
Copy link
Contributor

Read UUID as 16-length byte array.

@bangjiehan
Copy link
Contributor Author

There might be some endianness problem about .Net GUID struct so return raw byte array just for now.

@Gsantomaggio
Copy link
Member

Thanks for the PR @bangjiehan .
May I ask to ask to add a test for it? If you have a way to generate a message with UUID you can do like I did here:
https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/main/Tests/Amqp10Tests.cs#L300

struct so return raw byte array just for now.

I Agree with that

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (29c5474) to head (270ec7b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   92.17%   92.23%   +0.05%     
==========================================
  Files         118      118              
  Lines       12048    12075      +27     
  Branches      929      930       +1     
==========================================
+ Hits        11105    11137      +32     
  Misses        723      723              
+ Partials      220      215       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio merged commit 18e63d1 into rabbitmq:main Mar 16, 2024
2 checks passed
@Gsantomaggio
Copy link
Member

Thank you @bangjiehan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants