Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch the update secrets #362

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Dispatch the update secrets #362

merged 1 commit into from
Feb 23, 2024

Conversation

Gsantomaggio
Copy link
Member

  • Dispatch to all the pool connections

Fixes the issue raised by @vivek-singh2 @lngvivek here: https://github.com/lngvivek/UpdateSecretIssueTest/blob/main/README.md

Do you have the chance to test it?
@vivek-singh2 @lngvivek

- Dispatch to all the pool connections

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (ac23f56) to head (c8eb4a3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   92.08%   92.07%   -0.01%     
==========================================
  Files         118      118              
  Lines       12021    12048      +27     
  Branches      927      929       +2     
==========================================
+ Hits        11069    11093      +24     
- Misses        739      740       +1     
- Partials      213      215       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lngvivek
Copy link

Thanks @Gsantomaggio, I tested this and it looks fine.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review February 23, 2024 14:51
@Gsantomaggio Gsantomaggio merged commit bf6f5bf into main Feb 23, 2024
2 checks passed
@Gsantomaggio Gsantomaggio deleted the dispatch_update_secrets branch February 23, 2024 14:51
@Gsantomaggio Gsantomaggio added the bug Something isn't working label Feb 23, 2024
@Gsantomaggio Gsantomaggio added this to the 1.8.1 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants