Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer connected only to the followers #352

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

Gsantomaggio
Copy link
Member

Fixes #351

Fixes #351

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3d8e55) 92.14% compared to head (8138f53) 92.02%.

❗ Current head 8138f53 differs from pull request most recent head cfb6b24. Consider uploading reports for the commit cfb6b24 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   92.14%   92.02%   -0.12%     
==========================================
  Files         116      116              
  Lines       11680    11719      +39     
  Branches      909      910       +1     
==========================================
+ Hits        10762    10784      +22     
- Misses        713      733      +20     
+ Partials      205      202       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio marked this pull request as ready for review February 6, 2024 08:26
@Gsantomaggio
Copy link
Member Author

@francescopessina87 do you have an opportunity to test it?

LookupLeaderOrRandomReplicasConnection

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@francescopessina87
Copy link

@francescopessina87 do you have an opportunity to test it?

@Gsantomaggio yes I tested it against a 3 node and a 5 node cluster and seems to work properly 👍

@Gsantomaggio
Copy link
Member Author

Thank you @francescopessina87 ! Let's merge it!

@Gsantomaggio Gsantomaggio merged commit 66b9cab into main Feb 6, 2024
2 checks passed
@Gsantomaggio Gsantomaggio deleted the consumer_connect_only_followers branch February 6, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer connecting to leader node
2 participants