Implement Deduplicating Producer #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #227 Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Codecov ReportBase: 92.84% // Head: 93.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 92.84% 93.00% +0.16%
==========================================
Files 96 98 +2
Lines 8424 8562 +138
Branches 655 662 +7
==========================================
+ Hits 7821 7963 +142
+ Misses 469 465 -4
Partials 134 134
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
Should this be |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Gsantomaggio
changed the title
Zerpet
previously approved these changes
Feb 13, 2023
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Zerpet
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
Implement the
DeduplicationProducermake theProducerConfig.Referencedeprecated.The
Producerdoes not need theReferenceto work.Referenceis needed only for the Deduplication part.The low-level Class is the
RawProducerclass; this class sets the correct parameters to enable the deduplication and to make it easy to use.Signed-off-by: Gabriele Santomaggio G.santomaggio@gmail.com