Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multi types in the stream #229

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Handle multi types in the stream #229

merged 2 commits into from
Feb 3, 2023

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Feb 2, 2023

Fixes #226

Signed-off-by: Gabriele Santomaggio G.santomaggio@gmail.com

Fixes #226
Add tests

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio mentioned this pull request Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 92.33% // Head: 92.64% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (e56ab02) compared to base (b5bfe4c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   92.33%   92.64%   +0.30%     
==========================================
  Files          94       95       +1     
  Lines        8262     8343      +81     
  Branches      651      653       +2     
==========================================
+ Hits         7629     7729     +100     
+ Misses        494      478      -16     
+ Partials      139      136       -3     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/Client.cs 92.76% <100.00%> (+0.91%) ⬆️
RabbitMQ.Stream.Client/Connection.cs 92.03% <100.00%> (+2.86%) ⬆️
RabbitMQ.Stream.Client/Deliver.cs 95.45% <100.00%> (-0.20%) ⬇️
RabbitMQ.Stream.Client/IProducer.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/RawConsumer.cs 84.30% <100.00%> (-1.22%) ⬇️
RabbitMQ.Stream.Client/RawProducer.cs 86.91% <100.00%> (+6.19%) ⬆️
RabbitMQ.Stream.Client/Reliable/Producer.cs 77.70% <100.00%> (ø)
Tests/MultiThreadTests.cs 100.00% <100.00%> (ø)
Tests/RawConsumerSystemTests.cs 100.00% <100.00%> (ø)
Tests/RawProducerSystemTests.cs 98.95% <100.00%> (+<0.01%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukebakken lukebakken merged commit ea72747 into main Feb 3, 2023
@lukebakken lukebakken deleted the fix_handle_subentry_v2 branch February 3, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading stream with multi type: Compress ZIP/None and Standard messages
2 participants