Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cuttlefish to 3.1.0 #6041

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken self-assigned this Oct 6, 2022
@lukebakken lukebakken force-pushed the lukebakken/cuttlefish-upgrade branch from ba645bc to dd4c3e1 Compare October 7, 2022 14:41
@lukebakken
Copy link
Collaborator Author

Here is how I tested on Linux:

  • Create a generic unix package from this branch.
  • Clone this repository: https://github.com/lukebakken/rabbitmq-server-6041
  • cd to that clone, and run setup.sh. It'll generate the correct rabbitmq.conf and rabbitmq-env.conf files for you.
  • Start the generic unix package this way:
    RABBITMQ_CONF_ENV_FILE="/path/to/rabbitmq-env.conf" ./sbin/rabbitmq-plugins enable rabbitmq_management rabbitmq_top
    LOG=debug RABBITMQ_ALLOW_INPUT=true RABBITMQ_CONF_ENV_FILE="/path/to/rabbitmq-env.conf" ./sbin/rabbitmq-server
    
  • Visit https://localhost:15671 to verify HTTPS
  • Connect an AMQPS client to the server, or use openssl:
    openssl s_client -host localhost -port 5671 -CAfile './RabbitMQ Sérvér - Евгений/certs/ca_certificate.pem'
    
  • Investigate the output and log files to ensure there aren't any lists of integers or mis-encoded unicode strings. You may still see a few that will be resolved in my next PR to convert all ~s and ~p formats to their unicode equivalent.
  • Click around the management UI to ensure no 500s are returned, and that strings look correct
  • Create a vhost named using strings with non-ASCII, non latin characters, like RabbitMQ Sérvér/Евгений. I also used Евгений for the description and a tag value like Евгений, foo bar baz , Sérvér, which correctly ends up as three tags:
    $ ./sbin/rabbitmqctl list_vhosts name tags
    Listing vhosts ...
    name    tags
    /       []
    RabbitMQ Sérvér/Евгений [Евгений, foo bar baz, Sérvér]
    

@lukebakken lukebakken marked this pull request as ready for review October 7, 2022 21:19
@lukebakken lukebakken force-pushed the lukebakken/cuttlefish-upgrade branch from dd4c3e1 to 02e3e00 Compare October 7, 2022 21:36
@michaelklishin
Copy link
Member

Works as advertised:

Screen Shot 2022-10-08 at 09 00 06

Screen Shot 2022-10-08 at 08 59 41

Although per AMQP 0-9-1 spec, entity names are supposed to be ASCII. But directories with
Latin and Russian Cyrillic characters are accepted from rabbitmq.conf just fine 👍👍

@michaelklishin michaelklishin added this to the 3.10.9 milestone Oct 8, 2022
@michaelklishin michaelklishin merged commit c9587e4 into main Oct 8, 2022
@michaelklishin michaelklishin deleted the lukebakken/cuttlefish-upgrade branch October 8, 2022 05:02
michaelklishin added a commit that referenced this pull request Oct 8, 2022
michaelklishin added a commit that referenced this pull request Oct 8, 2022
Upgrade cuttlefish to 3.1.0 (backport #6041) (backport #6052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants