Add client-side TLS options support to Consul peer discovery #5155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces TLS-related options support to Consul peer discovery, like 87bbf0c did for etc.
Closes #5116.
Kudos to @dcorbacho for helping me with Meck-based tests.
QA Environment
It took some effort to set up Consul with TLS for client connections, even though Consul docs are pretty great.
However, there are several caveats:
Here is how I started Consul (a single server node with bootstrapping enabled):
# HTTPS port MUST be enabled explicitly even if config file has TLS settings consul agent -config-file=./config.hcl -https-port 8501
Here is the
rabbitmq.conf
used:Here is the Consul config in HCL: