Allow dynamic Shovels specify queue x-arguments when topology is declared #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when shovels declare queues, it is currently not possible to declare a quorum queue. Closes #2798.
michaelklishin
changed the title
michaelklishin
added a commit
that referenced
this pull request
Feb 10, 2021
Allow dynamic Shovels specify queue x-arguments when topology is declared (cherry picked from commit 7725db9) Conflicts: deps/rabbit/src/rabbit_amqqueue.erl
|
Backported to |
michaelklishin
added a commit
that referenced
this pull request
Feb 25, 2021
Allow dynamic Shovels specify queue x-arguments when topology is declared (cherry picked from commit 7725db9) Conflicts: deps/rabbit/src/rabbit_amqqueue.erl
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes dynamic shovels recognize two new options,
"src-queue-args"and"dest-queue-args", respectively.They are passed for optional queue arguments and should be used for the arguments that cannot be set using a policy, such as the type of the queue.
For everything else, policies is the right choice.
This way Shovels can be instructed to declare quorum queues, e.g. on the destination side.
Closes #2798.