Adding option to enforce CRL checks for server certificates. #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeekToDestroy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@SeekToDestroy Thank you for signing the Contributor License Agreement! |
michaelklishin
added a commit
that referenced
this pull request
Dec 4, 2018
|
@SeekToDestroy thank you. Note that I renamed the option to match .NET's own argument naming (and use a bit more established language around CRLs). |
|
@SeekToDestroy by the way, you did well with your first PR on GitHub 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed it so the consumers of the library can decided if they want CRL validation on the stream without having to write custom code to handle it in the validation callback.
Note if I am in wrong place: I am a 20+ year TFS guy, first github commit, so I could be checking in the entirely wrong place as the vernacular is confusing as hell.