Reintroduce a Uri property on ConnectionFactory. #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-introduces a Uri property in favour of the SetUri method. Other configuration is set using properties and although the code in SetUri is a bit more complex it makes sense to have a bit more consistency. [#147448071]
lukebakken
reviewed
Jun 19, 2017
| fh.WriteTimeout = Math.Max(SocketWriteTimeout, RequestedHeartbeat * 1000); | ||
| // TODO: add user-provided configurator, like in the Java client | ||
| return fh; | ||
| } | ||
|
|
||
| public void SetUri(Uri uri) | ||
| private void SetUri(Uri uri) |
There was a problem hiding this comment.
This change is going out via a new major version, right? 5.0.0 ?
There was a problem hiding this comment.
Yes, master will be 5.0 (5.0.1, to be specific, because an accidental release a few weeks ago).
There was a problem hiding this comment.
OK. I wanted to make sure this shouldn't be Obsolete-ed first.
michaelklishin
approved these changes
Jun 19, 2017
GitHubPang
added a commit
to GitHubPang/rabbitmq-dotnet-client
that referenced
this pull request
Sep 17, 2021
11 tasks
GitHubPang
added a commit
to GitHubPang/rabbitmq-website
that referenced
this pull request
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduces a Uri property in favour of the SetUri method.
Other configuration is set using properties and although the code in
SetUri is a bit more complex it makes sense to have a bit more
consistency.
[#147448071]
Fixes #330