Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NET6.0 to NET8.0 since NET6.0 is soon EOL #1707

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

danielmarbach
Copy link
Collaborator

@danielmarbach danielmarbach commented Oct 21, 2024

Proposed Changes

Net6.0 close to no longer be supported. Given that it took or takes longer to finalize the current major release, I figured I send in this PR since it seems odd to release a major version targeting NET6 that is then shortly after or already out of support.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@danielmarbach danielmarbach marked this pull request as ready for review October 21, 2024 20:48
@danielmarbach danielmarbach changed the title Upgrade NET6.0 to NET8.0 since NET6.0 is EOL Upgrade NET6.0 to NET8.0 since NET6.0 is soon EOL Oct 21, 2024
@lukebakken lukebakken self-assigned this Oct 21, 2024
@lukebakken lukebakken added this to the 7.0.0 milestone Oct 21, 2024
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukebakken lukebakken merged commit b751d92 into rabbitmq:main Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants