Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent naming for methods that return Tasks #1296

Closed
lukebakken opened this issue Feb 8, 2023 · 1 comment
Closed

Consistent naming for methods that return Tasks #1296

lukebakken opened this issue Feb 8, 2023 · 1 comment
Assignees
@lukebakken
Milestone
7.0.0

Comments

@lukebakken
Copy link
Contributor

https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1264/files#r1096793817

https://stackoverflow.com/questions/15951774/does-the-use-of-the-async-suffix-in-a-method-name-depend-on-whether-the-async

https://stackoverflow.com/a/15951824

The Task-based Asynchronous Pattern (TAP) dictates that methods should always return a Task (or Task) and be named with an Async suffix; this is separate from the use of async.
@lukebakken lukebakken added this to the 7.0.0 milestone Feb 8, 2023
@lukebakken lukebakken self-assigned this Feb 8, 2023
@lukebakken lukebakken mentioned this issue Feb 8, 2023
Merged
11 tasks
lukebakken added a commit to stebet/rabbitmq-dotnet-client that referenced this issue Mar 14, 2023
@lukebakken
All methods that return Tasks should have the Async suffix rabbitmq…
4aca463 
…#1296
lukebakken added a commit to stebet/rabbitmq-dotnet-client that referenced this issue Mar 14, 2023
@lukebakken
Add config to enforce TAP naming. Related to rabbitmq#1296
428b052
lukebakken added a commit to stebet/rabbitmq-dotnet-client that referenced this issue Mar 24, 2023
@lukebakken
All methods that return Tasks should have the Async suffix rabbitmq…
6dc6e4c 
…#1296
lukebakken added a commit to stebet/rabbitmq-dotnet-client that referenced this issue Mar 24, 2023
@lukebakken
Add config to enforce TAP naming. Related to rabbitmq#1296
187e771
lukebakken added a commit to stebet/rabbitmq-dotnet-client that referenced this issue Apr 12, 2023
@lukebakken
All methods that return Tasks should have the Async suffix rabbitmq…
2f55690 
…#1296
lukebakken added a commit to stebet/rabbitmq-dotnet-client that referenced this issue Apr 12, 2023
@lukebakken
Add config to enforce TAP naming. Related to rabbitmq#1296
86ac876
@lukebakken
Copy link
Contributor Author

Addressed by #1347 and future 7.0 PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@lukebakken