Validate command reply modes #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
commented
Oct 18, 2022
| {call, From} -> | ||
| {keep_state, State0, [{reply, From, Error}]}; | ||
| _ -> | ||
| {keep_state, State0, []} |
There was a problem hiding this comment.
For pipeline commands, the command is silently discarded here if the reply mode is unrecognized. Should we log a message or exit so it's more noticeable?
There was a problem hiding this comment.
I think that is ok as pipelining always have to account for commands going missing and ensure resends when detected
There was a problem hiding this comment.
On second thought we could add a counter for these. That would make them detectable at least
`ra_server:command_reply_mode()` was not previously validated on the `ra_server`-side. If a command were sent with an unknown reply mode, the Ra server would never reply or notify the caller. Sending an unknown reply mode might happen when a client sends a new command to a Ra server which is operating on an old version of Ra. This change validates reply modes within the `ra_server`, replying with an error tuple when an invalid reply mode is passed.
the-mikedavis
force-pushed
the
md-validate-reply-mode
branch
from
3f1d74d to
be203b9
Compare
kjnilsson
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Command reply modes (
ra_server:command_reply_mode()) were not previously validated. If an old Ra system were sent a reply mode introduced in some new change, the Ra system would never reply or notify the caller. With this change, the caller receives an error tuple reply for the unknown mode.This is necessary to mitigate the effects of adding new reply modes as in #314 in cases where senders of commands may be running newer Ra versions than a running Ra system.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
CONTRIBUTING.mddocument