Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eurostat 4.0.0 #283

Merged
merged 102 commits into from
Dec 19, 2023
Merged

eurostat 4.0.0 #283

merged 102 commits into from
Dec 19, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Dec 19, 2023

I suggest this version is uploaded to CRAN. I will run some final tests and post the results here before this is merged into master and submitted to CRAN

@pitkant pitkant requested a review from antagomir December 19, 2023 14:50
Merge branch 'master' into v4

# Conflicts:
#	revdep/library.noindex/eurostat/new/lubridate/NEWS.md
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 182 lines in your changes are missing coverage. Please review.

Comparison is base (dc987e7) 67.18% compared to head (31869b7) 76.41%.

Files Patch % Lines
R/get_eurostat.R 72.10% 53 Missing ⚠️
R/set_eurostat_toc.R 35.82% 43 Missing ⚠️
R/get_eurostat_json.R 64.19% 29 Missing ⚠️
R/set_eurostat_cache.R 0.00% 16 Missing ⚠️
R/label_eurostat.R 89.09% 12 Missing ⚠️
R/cut_to_classes.R 28.57% 10 Missing ⚠️
R/search_eurostat.R 50.00% 9 Missing ⚠️
R/utils.R 62.50% 6 Missing ⚠️
R/tidy_eurostat.R 96.96% 2 Missing ⚠️
R/eurostat-defunct.R 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   67.18%   76.41%   +9.22%     
==========================================
  Files          24       23       -1     
  Lines        1024     1132     +108     
==========================================
+ Hits          688      865     +177     
+ Misses        336      267      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitkant
Copy link
Member Author

pitkant commented Dec 19, 2023

Checked on devtools::check_win_devel, devtools::check_win_release and devtools::check_win_oldrelease, all ok. Checked locally under

* using R version 4.3.2 (2023-10-31)
* using platform: aarch64-apple-darwin20 (64-bit)
* R was compiled by
    Apple clang version 14.0.0 (clang-1400.0.29.202)
    GNU Fortran (GCC) 12.2.0
* running under: macOS Sonoma 14.2

All ok except for 1 note:

Found the following (possibly) invalid URLs:
  URL: https://twitter.com/ropengov
    From: README.md
    Status: 403
    Message: Forbidden

This is due to Twitter API changes, the URL works ok

@antagomir
Copy link
Member

Really cool

@antagomir antagomir merged commit 6425c8b into master Dec 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants