Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance search_eurostat(), TOC handling, documentation #271

Merged
merged 12 commits into from
Sep 12, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Aug 29, 2023

  • Use inheriting in documentation where possible to avoid things being outdated in some parts of the package
  • Include NEWS.md in the R package build

@pitkant
Copy link
Member Author

pitkant commented Aug 31, 2023

  • Allow search_eurostat() to search from TOC codes in addition to titles by adding new column argument (as described in issue add code search to search_eurostat  #86 )
  • Replace empty spaces in eurostat TOC object names (column names) with ., making subsetting TOC easier

@pitkant
Copy link
Member Author

pitkant commented Aug 31, 2023

  • Add hierarchy column to TOC, possibly making it possible to download whole folders with a single command in the future (as described in issue get_eurostat folder handling #226)

@pitkant pitkant linked an issue Sep 1, 2023 that may be closed by this pull request
@pitkant
Copy link
Member Author

pitkant commented Sep 1, 2023

@pitkant pitkant changed the title Improve documentation Enhance search_eurostat() and TOC handling Sep 1, 2023
@pitkant pitkant linked an issue Sep 1, 2023 that may be closed by this pull request
@pitkant
Copy link
Member Author

pitkant commented Sep 4, 2023

  • Update documentation on dataset filtering and start using new URL for Eurostat dictionaries

@pitkant pitkant changed the title Enhance search_eurostat() and TOC handling Enhance search_eurostat(), TOC handling, documentation Sep 4, 2023
@pitkant
Copy link
Member Author

pitkant commented Sep 7, 2023

  • Previous push broke some functions that needed to be either rewritten or given a temporary fix.
  • Rewrite label_eurostat_tables()
  • Deprecate label_eurostat_vars() (meaning it still works)
  • Create a temporary function label_eurostat_vars2() that will replace label_eurostat_vars() when it stops working. Do not use label_eurostat_vars2() in any scripts, it's mainly for testing purposes
  • Testing fetching dataset metadata from SDMX API SDMX-ML files, might be worthwhile to use this approach more widely as replacements to label_eurostat and get_eurostat_dic functionalities

@pitkant pitkant marked this pull request as ready for review September 12, 2023 11:06
@pitkant pitkant merged commit 1fb6f28 into get_bibentry Sep 12, 2023
@pitkant pitkant mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant