Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date handling (issue #251) #256

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix date handling (issue #251) #256

merged 1 commit into from
Mar 7, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Mar 7, 2023

Fixes the following error described in issue #251 by @lz1nwm:

Warning message:
In eurotime2date(x, last = TRUE) :
Unknown time code, -. No date conversion was made.

get_eurostat (and get_eurostat_json) now use eurotime2date2 function instead of the old eurotime2date function.

@pitkant pitkant requested a review from antagomir March 7, 2023 10:29
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #256 (aaf1179) into master (3e7ad99) will not change coverage.
The diff coverage is 0.00%.

❗ Current head aaf1179 differs from pull request most recent head 30d22e6. Consider uploading reports for the commit 30d22e6 to get more accurate results

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files          24       24           
  Lines        1024     1024           
=======================================
  Hits          688      688           
  Misses        336      336           
Impacted Files Coverage Δ
R/get_eurostat.R 52.45% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pitkant pitkant merged commit a1c1459 into master Mar 7, 2023
@pitkant pitkant deleted the pitkant-4 branch August 1, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants