Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CRAN release #254

Merged
merged 5 commits into from
Feb 27, 2023
Merged

New CRAN release #254

merged 5 commits into from
Feb 27, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Feb 22, 2023

I have

  • successfully run package tests locally (macOS) and on devtools::check_win_devel
  • added cran-comments.md that describe the abovementioned results
  • checked reverse dependencies with revdepcheck package and added revdep folder to package repository
  • updated the version number and date in DESCRIPTION and most recent updates in NEWS.md
  • updated the package vignette slightly by adding a list of publications that utilise the eurostat package in their work
  • removed a failing workflow, render-rmarkdown
    for a new CRAN release.

@antagomir: you're the package maintainer so maybe you should submit the package to CRAN.

@pitkant pitkant requested a review from antagomir February 22, 2023 13:46
@pitkant pitkant marked this pull request as ready for review February 22, 2023 13:46
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #254 (dc18da5) into master (876b383) will not change coverage.
The diff coverage is n/a.

❗ Current head dc18da5 differs from pull request most recent head 5702191. Consider uploading reports for the commit 5702191 to get more accurate results

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   67.22%   67.22%           
=======================================
  Files          24       24           
  Lines        1022     1022           
=======================================
  Hits          687      687           
  Misses        335      335           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@antagomir
Copy link
Member

Feel free to merge if no more changes coming.

@pitkant pitkant merged commit 8370876 into master Feb 27, 2023
@pitkant pitkant deleted the pitkant-3 branch March 7, 2023 10:20
@pitkant pitkant mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants