Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating json API #252

Merged
merged 5 commits into from
Feb 6, 2023
Merged

Migrating json API #252

merged 5 commits into from
Feb 6, 2023

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Feb 1, 2023

This quick fix enables using old method of data retrieval in a relatively unchanged manner. Problem described in issues #243 (thank you @djhurio for reporting) and #251 (thank you @minemR for reporting).

For additional information about the API change, see the following Eurostat resources:

----EDIT
Fixed issue attribution

@pitkant pitkant requested review from antagomir and jhuovari February 1, 2023 20:12
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #252 (9f0bc9c) into master (97e3181) will increase coverage by 0.01%.
The diff coverage is 82.75%.

❗ Current head 9f0bc9c differs from pull request most recent head 9a3ab11. Consider uploading reports for the commit 9a3ab11 to get more accurate results

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   68.12%   68.14%   +0.01%     
==========================================
  Files          22       22              
  Lines         756      769      +13     
==========================================
+ Hits          515      524       +9     
- Misses        241      245       +4     
Impacted Files Coverage Δ
R/get_eurostat_json.R 61.76% <79.16%> (+1.09%) ⬆️
R/get_bibentry.R 88.00% <100.00%> (ø)
R/get_eurostat_geospatial.R 92.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, if this solves the issue for the time being.

Should then go to CRAN as well for the fix.

@antagomir antagomir merged commit b6a1db1 into master Feb 6, 2023
@pitkant pitkant deleted the pitkant branch February 7, 2023 11:10
@pitkant pitkant mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants