-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh datasets #246
Refresh datasets #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
I am starting to wonder why we have decided to include these super simlple data frames as rda files instead of plain text CSVs that could be accessed with system.file() and browsed in online code more easily. But perhaps that would be another PR.
If you see easily how to fix the GHA failure that would be great.. |
This fails even without my changes, i.e. from a fresh clone of the repo... |
I checked out v3.2.1 (the most recently tagged Release version) and I get errors there too... |
CRAN on the other end says the version is 3.7.12...I am, a little bit confused by the Release numbering...aaahhh, this is from the latest on github. |
I agree...on the other end I would have been interested with more details of EU members/candidates, i.e. membership timeline (membership application date, Candidature acceptance date, negotiations start, membership effective date).
(or even better iso2a code instead of country name ;-) ) |
Ok I opened an issue. I can approve the changes for this PR. and we have to find a fix for the builds. If you like you can add yourself on the DESCRIPTION file contributor list (ctb) as part of this PR before we merge. This may take until after the Xmas break at least... But if you can meanwhile find a fix, that would be greatly appreciated! |
I added myself as contributor: thanks. |
Ok I merge this now, we must troubleshoot the other issues separately and this does not seem to affect most of the key functionality. |
Thanks! |
fixes #245