Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RCMD action #242

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Fix RCMD action #242

merged 1 commit into from
Aug 18, 2022

Conversation

dieghernan
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #242 (2464947) into master (a866e98) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          22       22           
  Lines         756      756           
=======================================
  Hits          515      515           
  Misses        241      241           
Impacted Files Coverage Δ
R/check_access_to_data.R 56.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dieghernan
Copy link
Member Author

dieghernan commented Aug 18, 2022

Hi @antagomir @pitkant

I noticed that the R CMD Check was failing recently due to an error when installing the requiered packages.

This PR updates the action config file so now it works again, avoiding the errors on the action setup

Regards

@dieghernan dieghernan marked this pull request as ready for review August 18, 2022 08:35
@dieghernan dieghernan requested a review from pitkant August 18, 2022 10:52
Copy link
Member

@pitkant pitkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pitkant pitkant merged commit 97e3181 into master Aug 18, 2022
@dieghernan dieghernan deleted the fixaction branch August 18, 2022 12:25
@antagomir
Copy link
Member

antagomir commented Aug 23, 2022

Is this something we should consider also for other rOpenGov packages? @dieghernan @pitkant

@dieghernan
Copy link
Member Author

v2 version of the workflows provide better performance, BUT current versions should be working as well.

My opinion is that the action may be upgraded in case there is an issue with the workflow itself (i.e. dependencies not being installed) on a case-by-case basis. Otherwise there is not need to upgrade them in the short term.

@pitkant
Copy link
Member

pitkant commented Aug 24, 2022

v2 version of the workflows provide better performance, BUT current versions should be working as well.

My opinion is that the action may be upgraded in case there is an issue with the workflow itself (i.e. dependencies not being installed) on a case-by-case basis. Otherwise there is not need to upgrade them in the short term.

I agree that if things are working, there is no need to tinker. Of course r-lib's GitHub Actions get updated from time to time and old actions can have surprising issues if they are not updated regularly. One example (and this is more of a note to self) is that actions may stop working if they have Ubuntu 18.04 as platform, as mentioned in this tweet by Gábor Csárdi: https://twitter.com/GaborCsardi/status/1561694747235958790

@antagomir
Copy link
Member

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants