-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RCMD action #242
Fix RCMD action #242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 22 22
Lines 756 756
=======================================
Hits 515 515
Misses 241 241
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I noticed that the R CMD Check was failing recently due to an error when installing the requiered packages. This PR updates the action config file so now it works again, avoiding the errors on the action setup Regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Is this something we should consider also for other rOpenGov packages? @dieghernan @pitkant |
My opinion is that the action may be upgraded in case there is an issue with the workflow itself (i.e. dependencies not being installed) on a case-by-case basis. Otherwise there is not need to upgrade them in the short term. |
I agree that if things are working, there is no need to tinker. Of course r-lib's GitHub Actions get updated from time to time and old actions can have surprising issues if they are not updated regularly. One example (and this is more of a note to self) is that actions may stop working if they have Ubuntu 18.04 as platform, as mentioned in this tweet by Gábor Csárdi: https://twitter.com/GaborCsardi/status/1561694747235958790 |
Great! |
No description provided.