Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CRAN release (minor fix) #234

Merged
merged 5 commits into from
Feb 9, 2022
Merged

New CRAN release (minor fix) #234

merged 5 commits into from
Feb 9, 2022

Conversation

pitkant
Copy link
Member

@pitkant pitkant commented Feb 9, 2022

Message from CRAN Team:

'Packages which use Internet resources should fail gracefully with an informative message
if the resource is not available or has changed (and not give a check warning nor error).'

As CRAN tests are re-run regularly, I could not see what internet resource failure this message was exactly referring to.

I did the following small fixes to the package:

  • I ran package checks with Wi-Fi turned off and all NOTEs were related to checks not being able to resolve host in README, vignette, article URLs or checks not being able to access indices for different repositories. So there should not be any problems with package examples or vignettes causing any problems.
  • What was left to do was to double-check that problems with fickle internet resources were not accessed. Development version of the package has for a while had most vignettes turned into articles, as did CRAN version 3.7.5. Articles are now in ./vignettes/articles/ subfolder, not ./vignettes/website/, to make the folder structure conform to the default setting in usethis::use_article.
  • Articles themselves were checked for broken URLs and broken URLs were either removed or corrected.
  • There is a NOTE in the current eurostat check results page "Namespace in Imports field not imported from: ‘RColorBrewer’". Article maps.Rmd / "Map examples for the eurostat R package" uses this package in its example and therefore it should be retained. I have not been able to replicate this on my setup.

Tests have been run without any NOTEs, WARNINGs or ERRORs on devtools::check_win_devel and locally:

R version 4.1.2 (2021-11-01)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Monterey 12.2

For my part this package is ready for resubmission to CRAN.

@pitkant pitkant requested a review from antagomir February 9, 2022 08:36
@antagomir
Copy link
Member

still some errors in the final automated merge checks?

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #234 (723459a) into master (8010de0) will not change coverage.
The diff coverage is n/a.

❗ Current head 723459a differs from pull request most recent head 11c4459. Consider uploading reports for the commit 11c4459 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   68.12%   68.12%           
=======================================
  Files          22       22           
  Lines         756      756           
=======================================
  Hits          515      515           
  Misses        241      241           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8010de0...11c4459. Read the comment docs.

@pitkant
Copy link
Member Author

pitkant commented Feb 9, 2022

still some errors in the final automated merge checks?

Seems to pass now, there was a slight formatting error in DESCRIPTION

@antagomir antagomir merged commit b88e9d5 into master Feb 9, 2022
@pitkant pitkant deleted the pitkant_cranfix branch February 9, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants